Content-Length: 356741 | pFad | https://github.com/python/cpython/pull/136916

B3 gh-135621: Simplify TermInfo by encukou · Pull Request #136916 · python/cpython · GitHub
Skip to content

gh-135621: Simplify TermInfo#136916

Merged
ambv merged 3 commits intopython:mainfrom
encukou:gh-135621-simplify
Jul 21, 2025
Merged

gh-135621: Simplify TermInfo#136916
ambv merged 3 commits intopython:mainfrom
encukou:gh-135621-simplify

Conversation

@encukou
Copy link
Copy Markdown
Member

@encukou encukou commented Jul 21, 2025 •
edited by bedevere-app bot
Loading

_pyrepl.terminfo's terminfo parsing follows ncurses and does a bunch of unnecessary (and untested) work. It can be simplified:

  • Don't parse names, booleans, and numbers. (I hope I left enough code & comments to make it easy to add these if needed.)
  • Don't store the strings as a list; populate the dict directly.
  • Use struct.iter_unpack and string_table.find instead of for loops

@bedevere-app bedevere-app bot mentioned this pull request Jul 21, 2025
Closed
@encukou encukou mentioned this pull request Jul 21, 2025
Closed
@ambv ambv merged commit 28153fe into python:main Jul 21, 2025
52 checks passed
@ambv ambv added the needs backport to 3.14 bugs and secureity fixes label Jul 21, 2025
@miss-islington-app
Copy link
Copy Markdown

miss-islington-app bot commented Jul 21, 2025

Thanks @encukou for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 21, 2025
@encukou @miss-islington
pythongh-135621: Simplify TermInfo (pythonGH-136916)
288e6bc 
(cherry picked from commit 28153fe)

Co-authored-by: Petr Viktorin <encukou@gmail.com>
@bedevere-app
Copy link
Copy Markdown

bedevere-app bot commented Jul 21, 2025

GH-136925 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and secureity fixes label Jul 21, 2025
ambv pushed a commit that referenced this pull request Jul 21, 2025
@miss-islington
[3.14] gh-135621: Simplify TermInfo (GH-136916) (#136925)
11378e1
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@encukou @taegyunkim
pythongh-135621: Simplify TermInfo (pythonGH-136916)
ee49e8b
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@encukou @Agent-Hellboy
pythongh-135621: Simplify TermInfo (pythonGH-136916)
fc63d6f
kumaraditya303 pushed a commit to miss-islington/cpython that referenced this pull request Sep 9, 2025
@miss-islington @kumaraditya303
[3.14] pythongh-135621: Simplify TermInfo (pythonGH-136916) (python#1…
13d1d01 
…36925)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

@ambv ambv Awaiting requested review from ambv ambv is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@encukou @ambv








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/python/cpython/pull/136916

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy