gh-140474: Fix memory leak in array.array#140478
Merged
Merged
Conversation
ZeroIntensity
left a comment
ZeroIntensity
left a comment
Member
There was a problem hiding this comment.
The core fix looks good, but please add a test stressing this. We can remove it when we remove the u type code in 3.16.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
skirpichev
added
needs backport to 3.13
Member
|
This seems to be present in 3.13 and 3.14. |
ZeroIntensity
approved these changes
Oct 23, 2025
|
Thanks @StanFromIreland for the PR, and @ZeroIntensity for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 23, 2025
(cherry picked from commit aa9d0a6) Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 23, 2025
(cherry picked from commit aa9d0a6) Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
|
GH-140498 is a backport of this pull request to the 3.14 branch. |
|
GH-140499 is a backport of this pull request to the 3.13 branch. |
ZeroIntensity
pushed a commit
that referenced
this pull request
Oct 23, 2025
ZeroIntensity
pushed a commit
that referenced
this pull request
Oct 23, 2025
StanFromIreland
added a commit
to StanFromIreland/cpython
that referenced
this pull request
Dec 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four bytes is four bytes :-)