Improves web manifest, fixes icon pathing issue #2342
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This small PR improves the web manifest file.
Code Changes
/static/icons/manifest.json
so that they're resolved properly in browser.short_name
,description
, andstart_url
standalone
tominimal-ui
. This mode is like standalone, but adds a ⬅️ and 🔃 button in the title bar of the web app.Notes
There are two web manifest files: one in

/static/root
and another in/static/icons
. The latter is the one used on the web at sefaria.org, and it has the following icon resolution issue:The icon resolution issue is due to icons being resolved relative to the web app root, not the web manifest location. I've fixed this issue in this manifest file.
I've left the other manifest file paths untouched, as I don't know whether it's being used.