Content-Length: 246538 | pFad | http://github.com/Sefaria/Sefaria-Project/pull/2342

C1 Improves web manifest, fixes icon pathing issue by JudahGabriel · Pull Request #2342 · Sefaria/Sefaria-Project · GitHub
Skip to content

Improves web manifest, fixes icon pathing issue #2342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JudahGabriel
Copy link

Description

This small PR improves the web manifest file.

  • It fixes an icon pathing issue
  • It adds basic, standard properties to the web manifest file.

Code Changes

  • Updated the image paths for /static/icons/manifest.json so that they're resolved properly in browser.
  • Added a 512x512 image per standard requirements.
  • Added standard properties to the manifest file, including short_name, description, and start_url
  • Changed the web manifest display from standalone to minimal-ui. This mode is like standalone, but adds a ⬅️ and 🔃 button in the title bar of the web app.

Notes

There are two web manifest files: one in /static/root and another in /static/icons. The latter is the one used on the web at sefaria.org, and it has the following icon resolution issue:
image

The icon resolution issue is due to icons being resolved relative to the web app root, not the web manifest location. I've fixed this issue in this manifest file.

I've left the other manifest file paths untouched, as I don't know whether it's being used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/Sefaria/Sefaria-Project/pull/2342

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy