feat: [sc-29136] Add Version language-related attributes as frontend options in the version menu #2344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ted-attributes-as
…ted-attributes-as
…ted-attributes-as
There was a problem hiding this comment.
Pull Request Overview
This pull request adds new version attributes ("direction", "isSource", "isPrimary") to the admin version editor, extends backend validation in text model code, and updates the view to persist these new fields.
- Updates the frontend VersionBlock component to include dropdowns for text direction and checkboxes for isSource/isPrimary.
- Adds validations in the text model to enforce correct values and ensures at least one version remains primary.
- Updates the update_version view to include the new attributes when saving version records.
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| static/js/sefaria/sefaria.js | Added Romanian language mapping; no issues found. |
| static/js/VersionBlock/VersionBlock.jsx | Added new version fields and UI updates in the version editor. |
| sefaria/model/text.py | Extended validation to check new version attributes. |
| reader/views.py | Updated version update to persist the new attributes. |
Files not reviewed (1)
- static/css/s2.css: Language not supported
yitzhakc
reviewed
May 19, 2025
yitzhakc
approved these changes
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add fields to admin version editor: direction, isSource, isPrimary
Code Changes
In addition to front end changes, I also added some backend validation and minor css changes.