filter out existing notable sources from sources refs #2350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s and prioritize learning-team data sources in sorting
yonadavGit
force-pushed
the
bug/sc-32809/sources-added-manually-on-topic-pages-are
branch
from
5f1a18a to
17d9cc3
Compare
nsantacruz
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes a significant change to the
static/js/sefaria/sefaria.jsfile, specifically in the handling of sources in thetabs.sourcesobject. The main update involves filtering out references intabs.sources.refsthat are already present intabs["notable-sources"].refs.Improvements to sources handling:
static/js/sefaria/sefaria.js: Added a filter to remove references intabs.sources.refsthat are already included intabs["notable-sources"].refs. This ensures that thesourcestab does not duplicate references from thenotable-sourcestab.