Plugins #2400
Open
Plugins #2400
+444
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in conditinal experimental profile flag, add plugin django models
|
The preview deployment is ready. 🟢 Last updated at: 2025-04-03 18:27:28 CET |
| const scrollToRef = (sref) => { | ||
| if (sref) { | ||
| const query = `div[data-ref="${sref}"]`; | ||
| const element = document.querySelectorAll(query)[0]; |
There was a problem hiding this comment.
This would scroll on the first (and only first) matching text pane on the page, right? Not just the one immediately to the "left" of the plugin? That doesn't sound like the expected behavior...
Better to figure out how to pass an event that will query and scroll the appropriate React pane.
| if (sref) { | ||
| const query = `div[data-ref="${sref}"]`; | ||
| const element = document.querySelectorAll(query)[0]; | ||
| if (element) { |
There was a problem hiding this comment.
Have scrollToRef return a boolean so the plugin can know if the element was not in scope to scroll
|
|
||
| const scrollToRef = (sref) => { | ||
| if (sref) { | ||
| const query = `div[data-ref="${sref}"]`; |
There was a problem hiding this comment.
Will this match a reference like Genesis 2, or just Genesis 2.1?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several significant changes, primarily focusing on the integration of a plugin management system, enhancements to the user profile settings, and updates to various views and components to support the new functionalities.
Plugin Management System:
fields/file_fields.py: AddedGCSImageFieldFileandGCSImageFieldclasses to handle image storage on Google Cloud Storage.plugins/models.py: Created aPluginmodel to store plugin information, including name, description, URL, and image.plugins/admin.py: Registered thePluginmodel with the Django admin interface usingPluginAdmin.plugins/views.py: Added views to render the development version of a plugin and retrieve all plugins.sefaria/urls.py: Updated URL patterns to include routes for the plugin API.User Profile Enhancements:
sefaria/model/user_profile.py: Added anexperimentsfield to the user profile settings.reader/views.py: Included theexperimentsfield in the base properties for user profiles. [1] [2]Frontend Integration:
static/js/ConnectionsPanel.jsx: Added a new button for plugins in the connections panel, conditionally rendered based on theexperimentsfield. [1] [2]static/js/components/plugins/PluginList.jsx: Created a component to list and load plugins.static/js/components/plugins/PluginsComponent.jsx: Developed a component to toggle between plugin list and plugin creation views.static/js/components/plugins/WebComponentLoader.jsx: Implemented a component to dynamically load and display plugins.static/js/sefaria/sefaria.js: Added methods to fetch plugins and unpack theexperimentsproperty from base props. [1] [2]Miscellaneous Updates:
sefaria/settings.py: Registered thePluginsAppConfigin the Django settings.These changes collectively introduce a robust plugin management system, enhance user profile capabilities, and integrate new frontend components to support plugin interactions.