Content-Length: 278596 | pFad | http://github.com/Sefaria/Sefaria-Project/pull/2411

49 Hebrew newsletter form sign up producing wrong data in Salesforce by relyks · Pull Request #2411 · Sefaria/Sefaria-Project · GitHub
Skip to content

Hebrew newsletter form sign up producing wrong data in Salesforce #2411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

relyks
Copy link
Contributor

@relyks relyks commented Apr 11, 2025

Description

This fixes the order and type of parameters sent to Salesforce. The interface language and educator fields were in the wrong order and causing Hebrew users to be signed up for the wrong version of the newsletter mailing lists.

Notes

  • The existing data on Salesforce from previous submissions also needs to be fixed using a one-time script or flow to correct the order of the fields.
  • The user's desired newsletters may need to be resent from ActiveCampaign in their preferred language

…lesforce. Interface language and educator fields were switched
@relyks relyks requested review from nsantacruz and edamboritz April 11, 2025 21:35
@relyks relyks self-assigned this Apr 11, 2025
@relyks relyks requested a review from akiva10b April 24, 2025 11:29
Copy link
Contributor

@akiva10b akiva10b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see more uses of subscribe_to_lists that have not been updated in this PR (see dummy_crm.py)

@relyks
Copy link
Contributor Author

relyks commented May 6, 2025

I see more uses of subscribe_to_lists that have not been updated in this PR (see dummy_crm.py)

You're right. I'll change them. They aren't used in tests now or execute in production, but they could be in the future

@akiva10b akiva10b merged commit 68a4084 into master May 7, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/Sefaria/Sefaria-Project/pull/2411

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy