Logout from sheets module will redirect to sheets homepage #2425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ferent next param depends on module.
…ing url's next param.
There was a problem hiding this comment.
Pull Request Overview
This PR updates the logout functionality so that users logging out from the sheets module are redirected to the sheets homepage, while other modules continue to use the existing logic. Key changes include:
- Adding a new getLogoutUrl function in sefaria.js that builds the logout URL with an appropriate next parameter.
- Replacing all hard-coded '/logout' links in Header.jsx (and related components) with calls to Sefaria.getLogoutUrl().
- Overriding CustomLogoutView.get_next_page in sefaria/views.py to extract the next parameter from the URL.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| static/js/sefaria/sefaria.js | Adds a centralized getLogoutUrl function that builds a logout URL with a next param based on module. |
| static/js/Header.jsx | Updates logout links to use Sefaria.getLogoutUrl() instead of a hard-coded string. |
| sefaria/views.py | Overrides CustomLogoutView.get_next_page to prioritize the next param from the URL if provided. |
Comments suppressed due to low confidence (2)
static/js/sefaria/sefaria.js:3503
- [nitpick] Consider renaming the variable 'next' within this function to a more descriptive name, such as 'redirectModule', to improve code clarity.
getLogoutUrl: () => {
sefaria/views.py:87
- Ensure that the 'next' parameter obtained from the request is validated or sanitized to prevent potential open redirects if such checks are not already enforced elsewhere.
def get_next_page(self):
yitzhakc
approved these changes
May 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previuously we've used the Django CustomLogoutView and defined
LOGOUT_REDIRECT_URL.Now we'll override Django's
get_next_page, and get the next page from the next param of the request.Code Changes
sefaria.js - add function
getLogoutUrlthat defines once the logout url with the next param according to the module.Header.jsx - use
getLogoutUrlanywhere rather than a magic string.sefaria/views.py - override
CustomLogoutView.get_next_pagefor getting next from the url params if exists, rather fall to Django'sget_next_page.