Remove share settings from new editor. #2433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes the share settings UI elements from the ShareBox component in the new editor.
- Removed the JSX block that displayed share options allowing users to change collaboration settings.
- The removal simplifies the UI by eliminating unused share settings for non-applicable contexts.
Comments suppressed due to low confidence (1)
static/js/ConnectionsPanel.jsx:1453
- Since the share settings UI is removed, the updateShareOptions method (and any related code) appears to be unused. Consider removing this dead code to keep the component lean.
{this.state.sheet && Sefaria._uid === this.state.sheet.owner ?
schreibersefaria
approved these changes
Apr 28, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code Changes
Removes jsx for sharing settings from ShareBox in ConnectionsPanel.jsx.