perf: remove the sleep before runtime initialization #10033
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hereisok <hereisok@angai.wk@gmail.com>
tofarr
approved these changes
Aug 14, 2025
|
Nice work! |
chuckbutkus
pushed a commit
that referenced
this pull request
Aug 26, 2025
Signed-off-by: hereisok <hereisok@angai.wk@gmail.com> Co-authored-by: mamoodi <mamoodiha@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
End-user friendly description of the problem this fixes or functionality this introduces.
Summarize what the PR does, explaining any non-trivial design decisions.
Solve the problem of an extra 1s sleep during runtime initialization. The 1s sleep is to avoid the gap in the front-end WebSocket connection establishment, which may not accurately push messages. The new design checks whether there is a connection on the SIO object when pushing the first message, and shifts the wait here, improving the efficiency of message push.
Link of any specific issues this addresses: