Add llm disable stop word env var #10274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 13, 2025
xingyaoww
approved these changes
Aug 13, 2025
openhands/core/config/llm_config.py
Outdated
| # Note: this setting is actually global, unlike drop_params | ||
| modify_params: bool = Field(default=True) | ||
| disable_vision: bool | None = Field(default=None) | ||
| disable_stop_word: bool | None = Field(default=None) |
There was a problem hiding this comment.
Let's just default it to false?
There was a problem hiding this comment.
Changed in 005674c
Confirmed. It works with R1-0528 locally. |
enyst
pushed a commit
that referenced
this pull request
Aug 15, 2025
Co-authored-by: Xingyao Wang <xingyao@all-hands.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summarize what the PR does, explaining any non-trivial design decisions.
This PR adds the
LLM_DISABLE_STOP_WORDenv var. When this env var is set totrue, Open Hands will not populate the stop property in the request. This addresses #10158.