Content-Length: 494487 | pFad | https://github.com/All-Hands-AI/OpenHands/pull/11013

E7 Allow custom user by chuckbutkus · Pull Request #11013 · All-Hands-AI/OpenHands · GitHub
Skip to content

Conversation

chuckbutkus
Copy link
Collaborator

@chuckbutkus chuckbutkus commented Sep 18, 2025

This PR allows users to specify a specific runtime user to use for the runtime pods. It also allows disabling of the "su" commands in environments where using "su" is not allowed.

Also a couple of bug fixes in clustered and nested convo managers.


To run this PR locally, use the following command:

GUI with Docker:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:246d51a-nikolaik   --name openhands-app-246d51a   docker.all-hands.dev/all-hands-ai/openhands:246d51a

CLI with uvx:

uvx --python 3.12 --from git+https://github.com/All-Hands-AI/OpenHands@allow-custom-user openhands

Copy link
Contributor

github-actions bot commented Sep 30, 2025

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  enterprise/server
  clustered_conversation_manager.py 693
  saas_nested_conversation_manager.py
  openhands/runtime/impl/action_execution
  action_execution_client.py 129, 132-141
  openhands/runtime/impl/remote
  remote_runtime.py 417-433
  openhands/runtime/plugins/jupyter
  __init__.py 46-50
  openhands/runtime/plugins/vscode
  __init__.py 48-53, 93-96
  openhands/runtime/utils
  bash.py 210
  command.py
  openhands/utils
  http_session.py 27-31
Project Total  

This report was generated by python-coverage-comment-action

@chuckbutkus
Copy link
Collaborator Author

@OpenHands please fix the failing actions on PR #11013 at branch allow-custom-user

Copy link

openhands-ai bot commented Sep 30, 2025

I'm on it! chuckbutkus can track my progress at all-hands.dev

Copy link

openhands-ai bot commented Sep 30, 2025

I started investigating the failing GitHub Actions on PR #11013 for the "allow-custom-user" branch. Here's what I found:

Analysis Summary

I examined the PR changes which add support for custom user configuration through environment variables:

  • RUNTIME_USERNAME - allows specifying a custom runtime username
  • RUNTIME_UID - allows specifying a custom runtime user ID
  • SU_TO_USER - controls whether to use su commands (defaults to true)

The changes affect multiple files including runtime plugins (Jupyter, VSCode), bash session handling, command execution, and enterprise server components.

Testing Results

Linting Status: ✅ PASSED

  • Ran the full pre-commit linting suite with pre-commit run --config ./dev_config/python/.pre-commit-config.yaml --all-files
  • All linting checks passed successfully (trim whitespace, YAML validation, ruff, mypy, etc.)

Python Tests Status: ⏸️ INTERRUPTED

  • Was about to run the Python tests to identify specific test failures when the session was stopped

Next Steps Needed

To complete the fix for the failing GitHub Actions, the following steps would need to be completed:

  1. Run Python Tests: Execute the test suite to identify which specific tests are failing
  2. Fix Test Issues: Address any test failures related to the custom user functionality
  3. Verify Fixes: Re-run both linting and tests to ensure all issues are resolved
  4. Commit & Push: Push the fixes to update the PR

Since the linting is already passing, the failures are likely in the Python test suite, possibly related to the new environment variable handling or user switching logic in the runtime components.

View full conversation

@chuckbutkus chuckbutkus marked this pull request as ready for review September 30, 2025 17:44
Copy link

openhands-ai bot commented Oct 1, 2025

Looks like there are a few issues preventing this PR from being merged!

  • GitHub Actions are failing:
    • Lint

If you'd like me to help, just leave a comment, like

@OpenHands please fix the failing actions on PR #11013 at branch `allow-custom-user`

Feel free to include any additional details that might help me get this PR into a better state.

You can manage your notification settings

@chuckbutkus chuckbutkus enabled auto-merge (squash) October 1, 2025 16:56
@chuckbutkus chuckbutkus merged commit 37daf06 into main Oct 1, 2025
23 checks passed
@chuckbutkus chuckbutkus deleted the allow-custom-user branch October 1, 2025 17:48
YakshithK pushed a commit to YakshithK/OpenHands that referenced this pull request Oct 2, 2025
Co-authored-by: openhands <openhands@all-hands.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants









ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/All-Hands-AI/OpenHands/pull/11013

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy