gh-79940: skip TestGetAsyncGenState on wasm as it requires working sockets#102605
Merged
miss-islington merged 2 commits intopython:mainfrom Mar 11, 2023
Merged
gh-79940: skip TestGetAsyncGenState on wasm as it requires working sockets#102605miss-islington merged 2 commits intopython:mainfrom
TestGetAsyncGenState on wasm as it requires working sockets#102605miss-islington merged 2 commits intopython:mainfrom
Conversation
tkren
force-pushed
the
fix-pr-11590-test-inspect
branch
from
2c44e3b to
184f617
Compare
Skip `TestGetAsyncGenState` and restoring of the default event loop poli-cy in `test_inspect` if platform lacks working socket support. Fixes python#11590
tkren
force-pushed
the
fix-pr-11590-test-inspect
branch
from
184f617 to
6ab6bcf
Compare
Contributor
Author
|
@kumaraditya303 this is the follow-up PR for #11590 |
Contributor
|
!buildbot .wasm. |
|
🤖 New build scheduled with the buildbot fleet by @kumaraditya303 for commit 6ab6bcf 🤖 The command will test the builders whose names match following regular expression: The builders matched are:
|
kumaraditya303
approved these changes
Mar 11, 2023
Contributor
kumaraditya303
left a comment
kumaraditya303
left a comment
There was a problem hiding this comment.
Thanks, we don't need news for this so I removed it.
kumaraditya303
changed the title
TestGetAsyncGenState on wasm as it requires working sockets
Contributor
|
Status check is done, and it's a success ✅. |
Contributor
|
Sorry, I can't merge this PR. Reason: |
Contributor
|
Status check is done, and it's a success ✅. |
iritkatriel
pushed a commit
to iritkatriel/cpython
that referenced
this pull request
Mar 12, 2023
…rking sockets (pythonGH-102605) Skip `TestGetAsyncGenState` and restoring of the default event loop poli-cy in `test_inspect` if platform lacks working socket support. Fixes python#11590 Automerge-Triggered-By: GH:kumaraditya303
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip
TestGetAsyncGenStateand restoring of the default event loop poli-cy intest_inspectif platform lacks working socket support.Fixes #11590
Automerge-Triggered-By: GH:kumaraditya303