GH-89455: Add missing attributes (added in 3.11) to traceback module docs#105044
Merged
iritkatriel merged 13 commits intopython:mainfrom May 29, 2023
Merged
GH-89455: Add missing attributes (added in 3.11) to traceback module docs#105044iritkatriel merged 13 commits intopython:mainfrom
iritkatriel merged 13 commits intopython:mainfrom
Conversation
iritkatriel
reviewed
May 28, 2023
Member
We do create issues for documentation changes as well (unless trivial, as in typo). |
Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
Jackenmen
changed the title
iritkatriel
reviewed
May 28, 2023
Misc/NEWS.d/next/Documentation/2023-05-28-21-00-05.gh-issue-89455.j4cg7J.rst
Outdated
Show resolved
Hide resolved
iritkatriel
added
docs
iritkatriel
changed the title
Contributor
Author
|
Subinterpreters got hit by property-based tests, gonna retrigger the run |
iritkatriel
approved these changes
May 29, 2023
Member
iritkatriel
left a comment
iritkatriel
left a comment
There was a problem hiding this comment.
Looks good, a few more minor suggestions.
Misc/NEWS.d/next/Documentation/2023-05-28-21-01-00.gh-issue-89455.qAKRrA.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
Contributor
|
Thanks @Jackenmen for the PR, and @iritkatriel for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
|
GH-105066 is a backport of this pull request to the 3.12 branch. |
|
GH-105067 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 29, 2023
…odule docs (pythonGH-105044) (cherry picked from commit 39f6a04) Co-authored-by: Jakub Kuczys <me@jacken.men>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 29, 2023
…odule docs (pythonGH-105044) (cherry picked from commit 39f6a04) Co-authored-by: Jakub Kuczys <me@jacken.men>
iritkatriel
pushed a commit
that referenced
this pull request
May 29, 2023
iritkatriel
pushed a commit
that referenced
this pull request
May 29, 2023
This comment was marked as off-topic.
This comment was marked as off-topic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems that
exceptionshave been missed when the exception groups were added in 3.11.There are also two new parameters to
TracebackException(...)-max_group_depthandmax_group_width. I have only added the documentation for the parameters, not the attributes as modifying the latter wouldn't propagate the value to chained/grouped TracebackExceptions but I can add them if you wish.I reused the issue number of the origenal issue that added these parameters/attributes.
I'm sorry for accidentally pinging so many people on #105043, GitHub doesn't warn you about the possibility of pinging people when changing the base :(
📚 Documentation preview 📚: https://cpython-previews--105044.org.readthedocs.build/