gh-119729: Use 't' in pkg-config file name for free-threaded build#119738
gh-119729: Use 't' in pkg-config file name for free-threaded build#119738colesbury merged 2 commits intopython:mainfrom
Conversation
For example, the free-threaded build now generates `lib/pkgconfig/python-3.13t.pc`.
colesbury
added
topic-free-threading
needs backport to 3.13
| AR= @AR@ | ||
| READELF= @READELF@ | ||
| SOABI= @SOABI@ | ||
| ABIFLAGS= @ABIFLAGS@ |
There was a problem hiding this comment.
LDVERSION is defined as $(VERSION)$(ABIFLAGS), so it's important to define ABIFLAGS first
|
I figured it would be good to start with a narrow change:
I think we'll want to consider doing more, such as only installing |
| @@ -0,0 +1,3 @@ | |||
| On POSIX systems, the pkg-config (``.pc``) files now include the ABI flags. | |||
| For example, the free-threaded build generates ``python-3.14t.pc`` and the | |||
There was a problem hiding this comment.
This also changes the debug one to have a "d" as well no?
There was a problem hiding this comment.
Yeah. Do you think that's problematic or should I just update the NEWS to make that more clear?
For context, we already do that for things like the include directories, which look like include/python3.14td for the free-threaded debug builds.
There was a problem hiding this comment.
Just update the news entry because that's the only change that affects normal builds (maybe even mentioning it in the what's new).
|
Thanks @colesbury for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
…ild (pythonGH-119738) For example, the free-threaded build now generates `lib/pkgconfig/python-3.13t.pc` and the debug build generates `lib/pkgconfig/python-3.13d.pc`. (cherry picked from commit 1c04c63) Co-authored-by: Sam Gross <colesbury@gmail.com>
|
GH-119797 is a backport of this pull request to the 3.13 branch. |
…ild (python#119738) For example, the free-threaded build now generates `lib/pkgconfig/python-3.13t.pc` and the debug build generates `lib/pkgconfig/python-3.13d.pc`.
…ild (python#119738) For example, the free-threaded build now generates `lib/pkgconfig/python-3.13t.pc` and the debug build generates `lib/pkgconfig/python-3.13d.pc`.
3 participants
For example, the free-threaded build now generates
lib/pkgconfig/python-3.13t.pc.pkg-configfiles (.pc) conflict between default and free-threaded build #119729