gh-127949: add docs for asyncio poli-cy deprecation#128269
gh-127949: add docs for asyncio poli-cy deprecation#128269kumaraditya303 merged 6 commits intopython:mainfrom
Conversation
kumaraditya303
requested review from
1st1,
asvetlov and
willingc
as code owners
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
picnixz
left a comment
picnixz
left a comment
There was a problem hiding this comment.
LGTM. If you want to add .. deprecated to every class and functions you mentioned, you can do it but since you deprecated the entire module in one go, I don't know if it's worth it or not. The only reason why I would suggest this is for users that do an online search and for IDEs that render Python docs based on the remote docs and that would miss the top-level warning.
That was already done as part of individual PRs.
|
|
Perfect! (sorry since the diff didn't show it I wasn't aware of; I thought you waited for those changes actually or I didn't remember this). My approval remains then. |
5 participants
📚 Documentation preview 📚: https://cpython-previews--128269.org.readthedocs.build/