gh-129403: Fix ValueError Messages#129419
Merged
Merged
Conversation
StanFromIreland
requested review from
1st1,
asvetlov,
kumaraditya303 and
willingc
as code owners
Member
Author
|
Requesting Review @sobolevn |
ZeroIntensity
left a comment
ZeroIntensity
left a comment
Member
There was a problem hiding this comment.
I think it's worth adding a blurb for this.
Member
Author
|
@ZeroIntensity @sobolevn NEWS added. |
ZeroIntensity
left a comment
ZeroIntensity
left a comment
Member
There was a problem hiding this comment.
It might be worth adding an assertRaiseRegex test case, but I'm fine without it.
…14159.rst Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
sobolevn
approved these changes
Jan 30, 2025
sobolevn
left a comment
sobolevn
left a comment
Member
There was a problem hiding this comment.
Thank you! We generally don't backport the error message changes, but these ones were incorrect, so I treat them as bugs, so I will backport these changes.
sobolevn
added
needs backport to 3.12
|
Thanks @StanFromIreland for the PR, and @sobolevn for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 30, 2025
…threading.Barrier` (pythonGH-129419) (cherry picked from commit bcb25d6) Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com> Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
|
GH-129468 is a backport of this pull request to the 3.13 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 30, 2025
…threading.Barrier` (pythonGH-129419) (cherry picked from commit bcb25d6) Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com> Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
|
GH-129469 is a backport of this pull request to the 3.12 branch. |
sobolevn
pushed a commit
that referenced
this pull request
Jan 30, 2025
…`threading.Barrier` (GH-129419) (#129469) gh-129403: Fix `ValueError` messages in `asyncio.Barrier` and `threading.Barrier` (GH-129419) (cherry picked from commit bcb25d6) Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com> Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
sobolevn
pushed a commit
that referenced
this pull request
Jan 30, 2025
…`threading.Barrier` (GH-129419) (#129468) gh-129403: Fix `ValueError` messages in `asyncio.Barrier` and `threading.Barrier` (GH-129419) (cherry picked from commit bcb25d6) Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com> Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
srinivasreddy
pushed a commit
to srinivasreddy/cpython
that referenced
this pull request
Feb 7, 2025
…threading.Barrier` (python#129419) Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All cases of this have been fixed confirmed by grep
grep -r "parties must be > 0"Barrier.__init__#129403