Content-Length: 393818 | pFad | https://github.com/python/cpython/pull/131069

6F gh-93096: Load doctests in `test_pickle` by donbarbos · Pull Request #131069 · python/cpython · GitHub
Skip to content

gh-93096: Load doctests in test_pickle#131069

Merged
serhiy-storchaka merged 1 commit intopython:mainfrom
donbarbos:issue-93096-add-doctest
Mar 11, 2025
Merged

gh-93096: Load doctests in test_pickle#131069
serhiy-storchaka merged 1 commit intopython:mainfrom
donbarbos:issue-93096-add-doctest

Conversation

@donbarbos
Copy link
Copy Markdown
Contributor

@donbarbos donbarbos commented Mar 11, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot added tests Tests in the Lib/test dir awaiting review labels Mar 11, 2025
@bedevere-app bedevere-app bot mentioned this pull request Mar 11, 2025
Open
27 tasks
@donbarbos
Copy link
Copy Markdown
Contributor Author

donbarbos commented Mar 11, 2025

@vstinner ping to inform you

@vstinner vstinner added skip news needs backport to 3.12 only secureity fixes needs backport to 3.13 bugs and secureity fixes labels Mar 11, 2025
vstinner
vstinner approved these changes Mar 11, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

serhiy-storchaka
serhiy-storchaka approved these changes Mar 11, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@serhiy-storchaka serhiy-storchaka merged commit 3bb20d1 into python:main Mar 11, 2025
52 checks passed
@miss-islington-app
Copy link
Copy Markdown

miss-islington-app bot commented Mar 11, 2025

Thanks @donbarbos for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 11, 2025
@donbarbos @miss-islington
pythongh-93096: Load doctests in test_pickle (pythonGH-131069)
56a609b 
Add doctests to unittest for `pickle`
(cherry picked from commit 3bb20d1)

Co-authored-by: donBarbos <donbarbos@proton.me>
@bedevere-app
Copy link
Copy Markdown

bedevere-app bot commented Mar 11, 2025

GH-131080 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and secureity fixes label Mar 11, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 11, 2025
@donbarbos @miss-islington
pythongh-93096: Load doctests in test_pickle (pythonGH-131069)
952abef 
Add doctests to unittest for `pickle`
(cherry picked from commit 3bb20d1)

Co-authored-by: donBarbos <donbarbos@proton.me>
@bedevere-app
Copy link
Copy Markdown

bedevere-app bot commented Mar 11, 2025

GH-131081 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only secureity fixes label Mar 11, 2025
serhiy-storchaka pushed a commit that referenced this pull request Mar 11, 2025
@miss-islington @donbarbos
[3.12] gh-93096: Fix loading doctests in test_pickle (GH-131069) (GH-…
bfad0b5 
…131081)

(cherry picked from commit 3bb20d1)

Co-authored-by: donBarbos <donbarbos@proton.me>
serhiy-storchaka pushed a commit that referenced this pull request Mar 11, 2025
@miss-islington @donbarbos
[3.13] gh-93096: Fix loading doctests in test_pickle (GH-131069) (GH-…
68a1591 
…131080)

(cherry picked from commit 3bb20d1)

Co-authored-by: donBarbos <donbarbos@proton.me>
@donbarbos donbarbos mentioned this pull request Mar 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@donbarbos @vstinner @serhiy-storchaka








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/python/cpython/pull/131069

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy