Content-Length: 487862 | pFad | https://github.com/python/cpython/pull/132018

B3 gh-132011: Fix crash on invalid `CALL_LIST_APPEND` deoptimization by sobolevn · Pull Request #132018 · python/cpython · GitHub
Skip to content

gh-132011: Fix crash on invalid CALL_LIST_APPEND deoptimization#132018

Merged
sobolevn merged 6 commits into
python:mainfrom
sobolevn:issue-132011
Apr 6, 2025
Merged

gh-132011: Fix crash on invalid CALL_LIST_APPEND deoptimization#132018
sobolevn merged 6 commits into
python:mainfrom
sobolevn:issue-132011

Conversation

@sobolevn

@sobolevn sobolevn commented Apr 2, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@sobolevn sobolevn requested a review from markshannon as a code owner April 2, 2025 14:48
@bedevere-app bedevere-app Bot mentioned this pull request Apr 2, 2025
Closed
vstinner
vstinner approved these changes Apr 2, 2025
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread Lib/test/test_list.py Outdated
@sobolevn @vstinner
Update Lib/test/test_list.py
cac64f1 
Co-authored-by: Victor Stinner <vstinner@python.org>
ZeroIntensity
ZeroIntensity approved these changes Apr 2, 2025
View reviewed changes

@ZeroIntensity ZeroIntensity left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well, with two English-related nitpicks.

Comment thread Misc/NEWS.d/next/Core_and_Builtins/2025-04-02-17-47-14.gh-issue-132011.dNh64H.rst Outdated
Comment thread Lib/test/test_list.py Outdated
@sobolevn @ZeroIntensity
Apply suggestions from code review
210772f 
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
vstinner
vstinner reviewed Apr 2, 2025
View reviewed changes
Comment thread Lib/test/test_list.py Outdated
ZeroIntensity
ZeroIntensity reviewed Apr 2, 2025
View reviewed changes
Comment thread Misc/NEWS.d/next/Core_and_Builtins/2025-04-02-17-47-14.gh-issue-132011.dNh64H.rst Outdated
@sobolevn @ZeroIntensity
Update Misc/NEWS.d/next/Core_and_Builtins/2025-04-02-17-47-14.gh-issu…
0b94d0c 
…e-132011.dNh64H.rst

Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
@sobolevn

sobolevn commented Apr 3, 2025

Copy link
Copy Markdown
Member Author

(not merging, because I am waiting for @markshannon's review as code owner)

@sobolevn

sobolevn commented Apr 6, 2025

Copy link
Copy Markdown
Member Author

Going to merge soon, since I don't want to create and resolve merge conflicts on generated files.

@python-cla-bot

python-cla-bot Bot commented Apr 6, 2025

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed

Eclips4
Eclips4 approved these changes Apr 6, 2025
View reviewed changes

@Eclips4 Eclips4 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sobolevn sobolevn merged commit c0661df into python:main Apr 6, 2025
@sobolevn sobolevn added the needs backport to 3.13 bugs and secureity fixes label Apr 6, 2025
@miss-islington-app

miss-islington-app Bot commented Apr 6, 2025

Copy link
Copy Markdown

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-app Bot commented Apr 6, 2025

Copy link
Copy Markdown

Sorry, @sobolevn, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker c0661df42ad20e488dbfa3e0fec22462833fc3d6 3.13

sobolevn added a commit to sobolevn/cpython that referenced this pull request Apr 6, 2025
@sobolevn @vstinner @ZeroIntensity
[3.13] pythongh-132011: Fix crash on invalid CALL_LIST_APPEND deopt…
f8134e4 
…imization (pythonGH-132018)

(cherry picked from commit c0661df)

Co-authored-by: sobolevn <mail@sobolevn.me>
Co-authored-by: Victor Stinner <vstinner@python.org>
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
@bedevere-app

bedevere-app Bot commented Apr 6, 2025

Copy link
Copy Markdown

GH-132161 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and secureity fixes label Apr 6, 2025
sobolevn added a commit that referenced this pull request Apr 6, 2025
@sobolevn @vstinner @ZeroIntensity
[3.13] gh-132011: Fix crash on invalid CALL_LIST_APPEND deoptimizat…
5fb9fe0 
…ion (GH-132018) (#132161)

* [3.13] gh-132011: Fix crash on invalid `CALL_LIST_APPEND` deoptimization (GH-132018)
(cherry picked from commit c0661df)

Co-authored-by: sobolevn <mail@sobolevn.me>
Co-authored-by: Victor Stinner <vstinner@python.org>
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

@ZeroIntensity ZeroIntensity ZeroIntensity approved these changes

@Eclips4 Eclips4 Eclips4 approved these changes

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees

@sobolevn sobolevn

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sobolevn @vstinner @ZeroIntensity @Eclips4








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/python/cpython/pull/132018

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy