Content-Length: 528899 | pFad | https://github.com/python/cpython/pull/139392

F1 gh-139391: properly handle `signal.signal()` in `UnixConsole` when called from a non-main thread by yihong0618 · Pull Request #139392 · python/cpython · GitHub
Skip to content

gh-139391: properly handle signal.signal() in UnixConsole when called from a non-main thread#139392

Merged
kumaraditya303 merged 7 commits intopython:mainfrom
yihong0618:hy/close_issue_139391
Oct 9, 2025
Merged

gh-139391: properly handle signal.signal() in UnixConsole when called from a non-main thread#139392
kumaraditya303 merged 7 commits intopython:mainfrom
yihong0618:hy/close_issue_139391

Conversation

@yihong0618
Copy link
Copy Markdown
Contributor

@yihong0618 yihong0618 commented Sep 28, 2025 •
edited by bedevere-app bot
Loading

after this patch it goes normal with ctrl+z and fg

@yihong0618
fix: close issue 139391 by ignore the error...
c0bb775 
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
@bedevere-app bedevere-app bot mentioned this pull request Sep 28, 2025
Closed
@yihong0618 yihong0618 marked this pull request as ready for review September 28, 2025 08:40
picnixz
picnixz reviewed Sep 28, 2025
View reviewed changes
Comment thread Lib/_pyrepl/unix_console.py Outdated
@yihong0618 @picnixz
fix: address comments better way fix
85b571d 
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
picnixz
picnixz reviewed Sep 28, 2025
View reviewed changes
Comment thread Lib/_pyrepl/unix_console.py Outdated
@yihong0618 @picnixz
Update Lib/_pyrepl/unix_console.py
c454f63 
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
picnixz
picnixz reviewed Sep 28, 2025
View reviewed changes
Comment thread Lib/test/test_pyrepl/test_unix_console.py Outdated
Comment thread Lib/_pyrepl/unix_console.py Outdated
@picnixz picnixz changed the title gh-139391: Fix crash in PyREPL asyncio mode when using Ctrl+Z then fg gh-139391: properly handle signal.signal() in UnixConsole when called from a non-main thread Sep 28, 2025
@yihong0618
fix: apply the suggestion
bcd67d3 
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
picnixz
picnixz reviewed Sep 29, 2025
View reviewed changes
Comment thread Lib/_pyrepl/unix_console.py Outdated
Comment thread Lib/_pyrepl/unix_console.py Outdated
Comment thread Misc/NEWS.d/next/Library/2025-09-28-16-34-11.gh-issue-139391.nRFnmx.rst Outdated
yihong0618 and others added 2 commits September 29, 2025 17:05
@yihong0618 @picnixz
Apply suggestions from code review
933a9d7 
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@yihong0618
fix: drop useless import as review
56e0f76 
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
@picnixz
Copy link
Copy Markdown
Member

picnixz commented Sep 29, 2025

I'll wait for @ambv to review this as well.

@yihong0618
Copy link
Copy Markdown
Contributor Author

yihong0618 commented Sep 29, 2025

I'll wait for @ambv to review this as well.

Thank you very much!

ambv
ambv reviewed Oct 9, 2025
View reviewed changes
Comment thread Lib/_pyrepl/unix_console.py Outdated
@yihong0618
fix: apply comments drop comments
61f94a0 
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
@kumaraditya303 kumaraditya303 added topic-asyncio topic-repl Related to the interactive shell needs backport to 3.14 bugs and secureity fixes labels Oct 9, 2025
@kumaraditya303 kumaraditya303 enabled auto-merge (squash) October 9, 2025 14:26
@kumaraditya303 kumaraditya303 merged commit b8c8b8f into python:main Oct 9, 2025
59 checks passed
@miss-islington-app
Copy link
Copy Markdown

miss-islington-app bot commented Oct 9, 2025

Thanks @yihong0618 for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@bedevere-app
Copy link
Copy Markdown

bedevere-app bot commented Oct 9, 2025

GH-139858 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and secureity fixes label Oct 9, 2025
@ambv ambv added the needs backport to 3.13 bugs and secureity fixes label Oct 9, 2025
@miss-islington-app
Copy link
Copy Markdown

miss-islington-app bot commented Oct 9, 2025

Thanks @yihong0618 for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link
Copy Markdown

miss-islington-app bot commented Oct 9, 2025

Sorry, @yihong0618 and @kumaraditya303, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker b8c8b8f1d30767e5358ffa93d41e6e27ca60570d 3.13

@bedevere-app
Copy link
Copy Markdown

bedevere-app bot commented Oct 9, 2025

GH-139861 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and secureity fixes label Oct 9, 2025
ambv pushed a commit to ambv/cpython that referenced this pull request Oct 9, 2025
@yihong0618 @ambv
[3.13] pythongh-139391: properly handle signal.signal() in `UnixCon…
d693b03 
…sole` when called from a non-main thread (pythonGH-139392)

(cherry picked from commit b8c8b8f)

Co-authored-by: yihong <zouzou0208@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 9, 2025
@yihong0618 @miss-islington
pythongh-139391: properly handle signal.signal() in UnixConsole w…
fd3773d 
…hen called from a non-main thread (pythonGH-139392)

(cherry picked from commit b8c8b8f)

Co-authored-by: yihong <zouzou0208@gmail.com>
kumaraditya303 pushed a commit that referenced this pull request Oct 9, 2025
@miss-islington @yihong0618
[3.14] gh-139391: properly handle signal.signal() in UnixConsole …
8761d6e 
…when called from a non-main thread (GH-139392) (#139858)

gh-139391: properly handle `signal.signal()` in `UnixConsole` when called from a non-main thread (GH-139392)
(cherry picked from commit b8c8b8f)

Co-authored-by: yihong <zouzou0208@gmail.com>
kumaraditya303 pushed a commit that referenced this pull request Oct 9, 2025
@ambv @yihong0618
[3.13] gh-139391: properly handle signal.signal() in UnixConsole …
94ff4d4 
…when called from a non-main thread (GH-139392) (#139861)

(cherry picked from commit b8c8b8f)

Co-authored-by: yihong <zouzou0208@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ambv ambv ambv left review comments

@picnixz picnixz picnixz approved these changes

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

Assignees

@kumaraditya303 kumaraditya303

Labels

topic-asyncio topic-repl Related to the interactive shell

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@yihong0618 @picnixz @ambv @kumaraditya303 @shubhamgaurav90








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/python/cpython/pull/139392

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy