Content-Length: 430780 | pFad | https://github.com/python/cpython/pull/145714

0D gh-145713: fix: make bytearray.resize thread-safe by KowalskiThomas · Pull Request #145714 · python/cpython · GitHub

gh-145713: fix: make bytearray.resize thread-safe#145714

Merged

kumaraditya303 merged 7 commits intopython:mainfrom

KowalskiThomas:kowalski/fix-make-bytearray-resize-thread-safe

Mar 11, 2026

Contributor

KowalskiThomas commented Mar 9, 2026 •

edited by bedevere-app bot

Loading

Description

This PR is a fix for #145713; it adds a critical section annotation to the argument clinic input for bytearray.resize.

Issue: bytearray.resize is not thread-safe #145713


          fix: make bytearray.resize thread-safe

a1af688

bedevere-app bot mentioned this pull request

bytearray.resize is not thread-safe #145713

Closed

bedevere-app bot added the awaiting review label


          chore: add news entry

Contributor

colesbury commented Mar 9, 2026

This looks good. The UBSan failures is unrelated to this PR (#142651).

Would you please add a regression test? The other free-threading related bytearray tests are in test_free_threading_bytearray in Lib/test/test_bytes.py.


          test: add a regression test for bytearray.resize thread safety

1ac4fd9

Contributor Author

KowalskiThomas commented Mar 10, 2026 •

edited

Loading

Thanks for suggesting that -- I added a test! (And confirmed it does fail if I run it without my changes on a free-threaded build.)


          Merge branch 'main' into kowalski/fix-make-bytearray-resize-thread-safe

7b2bd13

kumaraditya303 reviewed

View reviewed changes

Lib/test/test_bytes.py Show resolved Hide resolved

kumaraditya303 reviewed

View reviewed changes

Lib/test/test_bytes.py Show resolved Hide resolved


          test: update test based on review

a731e8c

kumaraditya303 reviewed

View reviewed changes

Lib/test/test_bytes.py Outdated Show resolved Hide resolved

kumaraditya303 reviewed

View reviewed changes

Lib/test/test_bytes.py Outdated Show resolved Hide resolved


          Apply suggestion from @kumaraditya303

16a80f8

kumaraditya303 reviewed

View reviewed changes

Lib/test/test_bytes.py Outdated Show resolved Hide resolved


          Apply suggestion from @kumaraditya303

12e2ad6

kumaraditya303 approved these changes

View reviewed changes

bedevere-app bot added awaiting merge and removed awaiting review labels

kumaraditya303 added topic-free-threading needs backport to 3.14 labels

kumaraditya303 merged commit c3955e0 into python:main

98 of 100 checks passed

miss-islington-app bot commented Mar 11, 2026

Thanks @KowalskiThomas for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

bedevere-app bot removed the awaiting merge label

miss-islington-app bot commented Mar 11, 2026

Sorry, @KowalskiThomas and @kumaraditya303, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker c3955e049fd5dbd3d92bc95fed4442964156293d 3.14

miss-islington-app bot assigned kumaraditya303

KowalskiThomas added a commit to KowalskiThomas/cpython that referenced this pull request


          pythongh-145713: make bytearray.resize thread-safe on free-threading (p…

69c1131

…ython#145714)

Co-authored-by: Kumar Aditya <kumaraditya@python.org>
(cherry picked from commit c3955e0)

KowalskiThomas mentioned this pull request

[3.14] gh-145713: make bytearray.resize thread-safe on free-threading (#145714) #145799

Merged

bedevere-app bot commented Mar 11, 2026

GH-145799 is a backport of this pull request to the 3.14 branch.

bedevere-app bot removed the needs backport to 3.14 label

kumaraditya303 added a commit that referenced this pull request


          [3.14] gh-145713: make bytearray.resize thread-safe on free-threading (…

c3ea6c2

…#145714) (#145799)

gh-145713: make bytearray.resize thread-safe on free-threading (#145714)


(cherry picked from commit c3955e0)

Co-authored-by: Kumar Aditya <kumaraditya@python.org>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic-free-threading